Changeset 10792

Timestamp:

02/14/10 01:03:47 (2 years ago)

Author:

adamk

Message:

Changed all for loops to foreach that should have been foreaches.

Converting more direct refresh calls to lock statements, which should improve startup speed a bit more and

Location:

trunk/Padre

Files:

• lib/Padre.pm (modified) (1 diff)
• lib/Padre/Action.pm (modified) (1 diff)
• lib/Padre/Action/Edit.pm (modified) (1 diff)
• lib/Padre/Action/File.pm (modified) (1 diff)
• lib/Padre/Config/Upgrade.pm (modified) (1 diff)
• lib/Padre/Document.pm (modified) (1 diff)
• lib/Padre/Document/Perl.pm (modified) (2 diffs)
• lib/Padre/Document/Perl/Help.pm (modified) (1 diff)
• lib/Padre/Document/Perl/Lexer.pm (modified) (1 diff)
• lib/Padre/MimeTypes.pm (modified) (1 diff)
• lib/Padre/PluginManager.pm (modified) (1 diff)
• lib/Padre/Task/HTTPClient/LWP.pm (modified) (1 diff)
• lib/Padre/Util.pm (modified) (1 diff)
• lib/Padre/Wx/Ack.pm (modified) (2 diffs)
• lib/Padre/Wx/Debugger.pm (modified) (1 diff)
• lib/Padre/Wx/Debugger/View.pm (modified) (1 diff)
• lib/Padre/Wx/Dialog/Preferences.pm (modified) (3 diffs)
• lib/Padre/Wx/Dialog/RegexEditor.pm (modified) (4 diffs)
• lib/Padre/Wx/Dialog/WindowList.pm (modified) (4 diffs)
• lib/Padre/Wx/Directory/TreeCtrl.pm (modified) (1 diff)
• lib/Padre/Wx/Editor.pm (modified) (4 diffs)
• lib/Padre/Wx/FindResult.pm (modified) (1 diff)
• lib/Padre/Wx/Main.pm (modified) (13 diffs)
• lib/Padre/Wx/Menu/File.pm (modified) (4 diffs)
• lib/Padre/Wx/Menu/Run.pm (modified) (3 diffs)
• lib/Padre/Wx/Menu/View.pm (modified) (1 diff)
• lib/Padre/Wx/Menubar.pm (modified) (3 diffs)
• lib/Padre/Wx/Notebook.pm (modified) (4 diffs)
• lib/Padre/Wx/Outline.pm (modified) (1 diff)
• lib/Padre/Wx/Syntax.pm (modified) (1 diff)
• lib/Padre/Wx/ToolBar.pm (modified) (2 diffs)
• script/padre (modified) (1 diff)
• share/examples/absolute_beginner/05_do_it_again.pl (modified) (1 diff)
• share/examples/absolute_beginner/07_short_salat.pl (modified) (4 diffs)
• t/94-padre-file-remote.t (modified) (2 diffs)
• xt/actions.t (modified) (1 diff)
• xt/mimetype.t (modified) (1 diff)

trunk/Padre/lib/Padre.pm

@@ -227 +227 @@
     # Process the action queue
     if ( defined $self->opts->{actionqueue} ) {
-        for my $action ( split( /\,/, $self->opts->{actionqueue} ) ) {
+        foreach my $action ( split( /\,/, $self->opts->{actionqueue} ) ) {
             next if $action eq ''; # Skip empty action names
             unless ( defined $self->actions->{$action} ) {

trunk/Padre/lib/Padre/Action.pm

@@ -196 +196 @@
         &{ $self->{event} }(@args);
     } elsif ( ref( $self->{event} ) eq 'ARRAY' ) {
-        for my $item ( @{ $self->{event} } ) {
+        foreach my $item ( @{ $self->{event} } ) {
             next if ref($item) ne 'CODE'; # TO DO: Catch error and source (Ticket #666)
             &{$item}(@args);

trunk/Padre/lib/Padre/Action/Edit.pm

@@ -280 +280 @@
                     my $text = $event->GetText;
                     my $selection;
-                    for my $item (@items) {
+                    foreach my $item (@items) {
                         if ( $item->{text} eq $text ) {
                             $selection = $item;

trunk/Padre/lib/Padre/Action/File.pm

@@ -400 +400 @@
         comment    => Wx::gettext('Remove the entries from the recent files list'),
         menu_event => sub {
+            my $lock = Padre::Current->main->lock('UPDATE', 'DB', 'refresh_recent');
             Padre::DB::History->delete( 'where type = ?', 'files' );
-            $self->update_recentfiles;
         },
     );

trunk/Padre/lib/Padre/Config/Upgrade.pm

@@ -38 +38 @@
     my $self = shift;
 
-    for my $storage ( 'human', 'host' ) {
+    foreach my $storage ( 'human', 'host' ) {
 
         if ( !defined( $self->$storage->{Version} ) ) {

trunk/Padre/lib/Padre/Document.pm

@@ -939 +939 @@
 
     # TO DO this is strange, do we really need to do it with all?
-    for my $i ( 0 .. 31 ) {
+    foreach my $i ( 0 .. 31 ) {
         $editor->StartStyling( 0, $i );
         $editor->SetStyling( $editor->GetLength, 0 );

trunk/Padre/lib/Padre/Document/Perl.pm

@@ -722 +722 @@
 
     #print "Name '$name'\n";
-    for my $i ( 0 .. @lines - 1 ) {
+    foreach my $i ( 0 .. @lines - 1 ) {
 
         #print "L: $lines[$i]\n";
@@ -933 +933 @@
     {
 
-        for my $candidate (
+        foreach my $candidate (
             $self->project_tagsfile, $config->perl_tags_file,
             File::Spec->catfile( $ENV{PADRE_HOME}, 'perltags' )

trunk/Padre/lib/Padre/Document/Perl/Help.pm

@@ -153 +153 @@
     my %seen;
     require File::Find::Rule;
-    for my $path (@INC) {
-        for my $file ( File::Find::Rule->name('*.pm')->in($path) ) {
+    foreach my $path (@INC) {
+        foreach my $file ( File::Find::Rule->name('*.pm')->in($path) ) {
             my $module = substr( $file, length($path) + 1 );
             $module =~ s/.pm$//;

trunk/Padre/lib/Padre/Document/Perl/Lexer.pm

@@ -361 +361 @@
     my $editor = $doc->editor;
 
-    for my $i ( 0 .. 31 ) {
+    foreach my $i ( 0 .. 31 ) {
         $editor->StartStyling( $styling_start_pos, $i );
         $editor->SetStyling( $styling_end_pos - $styling_start_pos, 0 );

trunk/Padre/lib/Padre/MimeTypes.pm

@@ -760 +760 @@
 sub menu_view_mimes {
     my %menu_view_mimes = ();
-    for my $mime_type ( keys %MIME_TYPES ) {
+    foreach my $mime_type ( keys %MIME_TYPES ) {
         my $mime_type_name = $MIME_TYPES{$mime_type}{name};
         if ($mime_type_name) {

trunk/Padre/lib/Padre/PluginManager.pm

@@ -741 +741 @@
     my $event = shift;
 
-    for my $module ( keys %{ $self->{plugins} } ) {
+    foreach my $module ( keys %{ $self->{plugins} } ) {
 
         # TODO: Re-enable the commented out error messages when the failing modules

trunk/Padre/lib/Padre/Task/HTTPClient/LWP.pm

@@ -60 +60 @@
     # content (POST data) and query (GET data) may be passed as hash ref's
     # and they're converted automatically:
-    for my $var ( 'query', 'content' ) {
+    foreach my $var ( 'query', 'content' ) {
         next unless ref( $self->{$var} ) eq 'HASH';
         $self->{$var} = join(

trunk/Padre/lib/Padre/Util.pm

@@ -416 +416 @@
     my $dir    = $olddir;
     while (1) {
-        for my $testfilename ( 'Makefile.PL', 'Build.PL', 'dist.ini', 'padre.yml' ) {
+        foreach my $testfilename ( 'Makefile.PL', 'Build.PL', 'dist.ini', 'padre.yml' ) {
             next unless -e File::Spec->catfile( $dir, $testfilename );
 

trunk/Padre/lib/Padre/Wx/Ack.pm

@@ -227 +227 @@
         my $is_regex = 1;
         my $wanted = ( $file_types =~ s/^no// ) ? 0 : 1;
-        for my $i ( App::Ack::filetypes_supported() ) {
+        foreach my $i ( App::Ack::filetypes_supported() ) {
             if ( $i eq $file_types ) {
                 $App::Ack::type_wanted{$i} = $wanted;
@@ -525 +525 @@
 # see t/module.t in ack distro
 sub fill_type_wanted {
-    for my $i ( App::Ack::filetypes_supported() ) {
+    foreach my $i ( App::Ack::filetypes_supported() ) {
         $App::Ack::type_wanted{$i} = undef;
     }

trunk/Padre/lib/Padre/Wx/Debugger.pm

@@ -163 +163 @@
     my $debugger = $main->debugger;
     my $count    = $debugger->GetItemCount;
-    for my $c ( 0 .. $count - 1 ) {
+    foreach my $c ( 0 .. $count - 1 ) {
         my $variable = $debugger->GetItemText($c);
 

trunk/Padre/lib/Padre/Wx/Debugger/View.pm

@@ -110 +110 @@
     my $self = shift;
 
-    for my $i ( 0 .. 1 ) {
+    foreach my $i ( 0 .. 1 ) {
         my $col = $self->GetColumn($i);
         $col->SetText( _get_title($i) );

trunk/Padre/lib/Padre/Wx/Dialog/Preferences.pm

@@ -797 +797 @@
     # TO DO: Convert the internal panels to use this
 
-    for my $module ( sort { Wx::gettext( $PANELS{$a} ) cmp Wx::gettext( $PANELS{$b} ); } ( keys(%PANELS) ) ) {
+    foreach my $module ( sort { Wx::gettext( $PANELS{$a} ) cmp Wx::gettext( $PANELS{$b} ); } ( keys(%PANELS) ) ) {
 
         # A plugin or panel should not crash Padre on error
@@ -1134 +1134 @@
     if ( $config->feature_config ) {
 
-        for my $feature (@Func_List) {
+        foreach my $feature (@Func_List) {
             $config->set(
                 'feature_' . $feature->[0],
@@ -1172 +1172 @@
     );
 
-    for my $module ( keys(%PANELS) ) {
+    foreach my $module ( keys(%PANELS) ) {
         my $preferences_page = $module->new();
         $preferences_page->save($data);

trunk/Padre/lib/Padre/Wx/Dialog/RegexEditor.pm

@@ -395 +395 @@
     $level = 0  unless $level;
     my @children = $parent->isa('PPIx::Regexp::Node') ? $parent->children : ();
-    for my $child (@children) {
+    foreach my $child (@children) {
         next if $child->content eq '';
         my $class_name = $child->class;
@@ -413 +413 @@
     @array    = () unless @array;
     my @elements = $parent->isa('PPIx::Regexp::Node') ? $parent->elements : ();
-    for my $element (@elements) {
+    foreach my $element (@elements) {
         my $content = $element->content;
         next if $content eq '';
@@ -492 +492 @@
         my @chars = split( //, $original_text );
         my $pos = 0;
-        for my $char (@chars) {
+        foreach my $char (@chars) {
             if ( $pos == $match_start ) {
                 $self->{matched_text}->BeginTextColour(Wx::wxRED);
@@ -527 +527 @@
     #   $self->{regex}->Clear;
     #   my @elements = _parse_regex_elements;
-    #   for my $element (@elements) {
+    #   foreach my $element (@elements) {
     #       my $class_name = $element->element->class;
     #       if ($class_name eq 'PPIx::Regexp::Token::CharClass::Simple') {

trunk/Padre/lib/Padre/Wx/Dialog/WindowList.pm

@@ -91 +91 @@
     my @pages;
 
-    for my $listitem ( 0 .. ( $self->_list->GetItemCount - 1 ) ) {
+    foreach my $listitem ( 0 .. ( $self->_list->GetItemCount - 1 ) ) {
         my $item = $self->{items}->[ $self->_list->GetItem($listitem)->GetData ];
         next unless $item->{selected};
@@ -273 +273 @@
     Wx::Event::EVT_BUTTON( $self, $bc, \&_on_butclose_clicked );
 
-    for my $button_no ( 0 .. $#{ $self->{buttons} || [] } ) {
+    foreach my $button_no ( 0 .. $#{ $self->{buttons} || [] } ) {
         if ( !defined( $self->{button_clicks}->[$button_no] ) ) {
             warn 'Too many buttons defined!';
@@ -389 +389 @@
 
     my $count;
-    for my $item ( @{ $self->{items} } ) {
+    foreach my $item ( @{ $self->{items} } ) {
         ++$count if $item->{selected};
     }
@@ -395 +395 @@
     my $method = $count ? 'Enable' : 'Disable';
 
-    for my $button ( @{ $self->{buttons} || [] } ) {
+    foreach my $button ( @{ $self->{buttons} || [] } ) {
         $button->[2]->$method if defined( $button->[2] );
     }

trunk/Padre/lib/Padre/Wx/Directory/TreeCtrl.pm

@@ -351 +351 @@
 
     # Loops thought the node's total children
-    for my $item ( 1 .. $self->GetChildrenCount($root) ) {
+    foreach my $item ( 1 .. $self->GetChildrenCount($root) ) {
 
         ( my $node, $cookie ) = $item == 1 ? $self->GetFirstChild($root) : $self->GetNextChild( $root, $cookie );

trunk/Padre/lib/Padre/Wx/Editor.pm

@@ -749 +749 @@
 }
 
-# when the focus is received by the editor
+# When the focus is received by the editor
 sub on_focus {
-    my ( $self, $event ) = @_;
-    my $doc = Padre::Current->document;
-
-    TRACE( "Focus received file: " . ( $doc->filename || '' ) ) if DEBUG;
-
-    my $main = $self->main;
-
-    # to show/hide the document specific Perl menu
+    my $self     = shift;
+    my $event    = shift;
+    my $main     = $self->main;
+    my $document = $main->current->document;
+    TRACE( "Focus received file: " . ( $document->filename || '' ) ) if DEBUG;
+
+    # To show/hide the document specific Perl menu
     # don't refresh on each focus event
-    $main->refresh_menu
-        if ( !defined( $main->{last_refresh_editor} ) )
-        or ( $main->{last_refresh_editor} ne $self );
-    $main->{last_refresh_editor} = $self;
-
-    $main->update_directory;
+    my $lock = $main->lock('UPDATE', 'refresh_menu', 'refresh_directory');
 
     # TO DO
@@ -771 +765 @@
     # we should restrict some of the updates to cases when we switch from one file to
     # another
-
     if ( $self->needs_manual_colorize ) {
         TRACE("needs_manual_colorize") if DEBUG;
         my $lexer = $self->GetLexer;
         if ( $lexer == Wx::wxSTC_LEX_CONTAINER ) {
-            $doc->colorize;
+            $document->colorize;
         } else {
-            $doc->remove_color;
+            $document->remove_color;
             $self->Colourise( 0, $self->GetLength );
         }
@@ -1212 +1205 @@
             $end--;
         }
-        for my $line ( $begin .. $end ) {
+        foreach my $line ( $begin .. $end ) {
 
             # insert $str (# or //)
@@ -1253 +1246 @@
             $end--;
         }
-        for my $line ( $begin .. $end ) {
+        foreach my $line ( $begin .. $end ) {
             my $first = $self->PositionFromLine($line);
             my $last  = $first + $length;

trunk/Padre/lib/Padre/Wx/FindResult.pm

@@ -195 +195 @@
     my $self = shift;
 
-    for my $i ( 0 .. 1 ) {
+    foreach my $i ( 0 .. 1 ) {
         my $col = $self->GetColumn($i);
         $col->SetText( _get_title($i) );

trunk/Padre/lib/Padre/Wx/Main.pm

@@ -114 +114 @@
     );
 
+    # Start with a simple placeholder title
+    $self->SetTitle('Padre');
+
     # Save a reference back to the parent IDE
     $self->{ide} = $ide;
@@ -124 +127 @@
     # so that we can do locking operations during startup.
     $self->{locker} = Padre::Locker->new($self);
-
-    # Determine the window title (needs ide & config)
-    $self->refresh_title;
 
     # Remember where the editor started from,
@@ -246 +246 @@
         Padre::Wx::ID_TIMER_POSTINIT,
         sub {
-            $_[0]->_timer_post_init;
+            $_[0]->timer_post_init;
         },
     );
@@ -656 +656 @@
 }
 
-sub _timer_post_init {
+sub timer_post_init {
     my $self    = shift;
     my $config  = $self->config;
@@ -1159 +1159 @@
 sub add_refresh_listener {
     my ( $self, @listeners ) = @_;
-    for my $l (@listeners) {
+    foreach my $l (@listeners) {
         if ( !grep { $_ eq $l } @{ $self->{refresh_listeners} } ) {
             Scalar::Util::weaken($l);
@@ -1267 +1267 @@
 =pod
 
+=head2 C<refresh_outline>
+
+    $main->refresh_outline;
+
+Force a refresh of the outline panel.
+
+=cut
+
+sub refresh_outline {
+    my $self = shift;
+    return unless $self->has_outline;
+    return if $self->locked('REFRESH');
+    return unless $self->menu->view->{show_outline}->IsChecked;
+    $self->outline->refresh;
+    return;
+}
+
+=pod
+
 =head3 C<refresh_menu>
 
@@ -1337 +1356 @@
     my $self = shift;
     return if $self->locked('REFRESH');
-    $self->menu->file->update_recentfiles;
+    $self->menu->file->refresh_recent;
 }
 
@@ -2616 +2635 @@
 }
 
-
-
-sub update_directory {
-    my $self = shift;
-
-    # update the directory listing
-    if ( $self->has_directory ) {
-        if ( $self->menu->view->{directory}->IsChecked ) {
-            $self->directory->refresh;
-        }
-    }
-
-}
-
-
 =pod
 
@@ -3315 +3319 @@
     }
 
-    my $lock = $self->lock('REFRESH');
+    my $lock     = $self->lock('REFRESH');
     my $document = Padre::Document->new( filename => $file, );
 
@@ -3398 +3402 @@
 
 sub create_tab {
-    my ( $self, $editor, $title ) = @_;
+    my $self   = shift;
+    my $editor = shift;
+    my $title  = shift;
     $title ||= '(' . Wx::gettext('Unknown') . ')';
+
+    my $lock = $self->lock('refresh');
     $self->notebook->AddPage( $editor, $title, 1 );
     $editor->SetFocus;
-    my $id = $self->notebook->GetSelection;
-    $self->refresh;
-    return $id;
+    return $self->notebook->GetSelection;
 }
 
@@ -3641 +3647 @@
 
     my @files;
-    for my $filename (@filenames) {
+    foreach my $filename (@filenames) {
 
         if ( $filename =~ /[\*\?]/ ) {
@@ -3810 +3816 @@
     SCOPE: {
         my $lock = $self->lock('refresh');
-        for my $reload_page_no ( 0 .. $#reload_pages ) {
+        foreach my $reload_page_no ( 0 .. $#reload_pages ) {
             $progress->update( $reload_page_no, ( $reload_page_no + 1 ) . '/' . scalar(@reload_pages) );
 
@@ -4444 +4450 @@
     SCOPE: {
         my $lock = $self->lock('refresh');
-        for my $close_page_no ( 0 .. $#close_pages ) {
+        foreach my $close_page_no ( 0 .. $#close_pages ) {
             $progress->update( $close_page_no, ( $close_page_no + 1 ) . '/' . scalar(@close_pages) );
 

trunk/Padre/lib/Padre/Wx/Menu/File.pm

@@ -257 +257 @@
     $self->{recentfiles}->AppendSeparator;
 
-    $self->update_recentfiles;
+    # NOTE: Do NOT do an initial fill during the constructor
+    # We'll do one later anyway, and the list is premature at this point.
+    # $self->refresh_recent;
 
     $self->AppendSeparator;
@@ -279 +281 @@
 
 sub title {
-    my $self = shift;
-
-    return Wx::gettext('&File');
+    Wx::gettext('&File');
 }
 
-
-
 sub refresh {
-    my $self    = shift;
-    my $current = _CURRENT(@_);
-    my $doc     = $current->document ? 1 : 0;
-
-    $self->{open_in_file_browser}->Enable($doc);
+    my $self     = shift;
+    my $current  = _CURRENT(@_);
+    my $document = $current->document ? 1 : 0;
+
+    $self->{open_in_file_browser}->Enable($document);
     if (Padre::Constant::WIN32) {
 
         #Win32
-        $self->{open_with_default_system_editor}->Enable($doc);
-        $self->{open_in_command_line}->Enable($doc);
+        $self->{open_with_default_system_editor}->Enable($document);
+        $self->{open_in_command_line}->Enable($document);
     } else {
 
@@ -304 +302 @@
         $self->{open_in_command_line}->Enable(0);
     }
-    $self->{close}->Enable($doc);
-    $self->{close_all}->Enable($doc);
-    $self->{close_all_but_current}->Enable($doc);
-    $self->{reload_file}->Enable($doc);
-    $self->{reload_all}->Enable($doc);
-    $self->{save}->Enable($doc);
-    $self->{save_as}->Enable($doc);
-    $self->{save_all}->Enable($doc);
-    $self->{print}->Enable($doc);
-    defined( $self->{open_session} ) and $self->{open_selection}->Enable($doc);
-    defined( $self->{save_session} ) and $self->{save_session}->Enable($doc);
-    $self->{docstat}->Enable($doc);
+    $self->{close}->Enable($document);
+    $self->{close_all}->Enable($document);
+    $self->{close_all_but_current}->Enable($document);
+    $self->{reload_file}->Enable($document);
+    $self->{reload_all}->Enable($document);
+    $self->{save}->Enable($document);
+    $self->{save_as}->Enable($document);
+    $self->{save_all}->Enable($document);
+    $self->{print}->Enable($document);
+    defined( $self->{open_session} ) and $self->{open_selection}->Enable($document);
+    defined( $self->{save_session} ) and $self->{save_session}->Enable($document);
+    $self->{docstat}->Enable($document);
 
     return 1;
 }
 
-sub update_recentfiles {
+sub refresh_recent {
     my $self = shift;
 
@@ -345 +343 @@
 
                     # Handle "File not found" situation
-                    Padre::DB::History->delete( 'where name = ? and type = ?', $file, 'files' );
-                    $self->update_recentfiles;
+                    Padre::Current->main->lock('UPDATE', 'DB', 'refresh_recent');
+                    Padre::DB::History->delete(
+                        'where name = ? and type = ?',
+                        $file, 'files',
+                    );
                     Wx::MessageBox(
                         sprintf( Wx::gettext("File %s not found."), $file ),

trunk/Padre/lib/Padre/Wx/Menu/Run.pm

@@ -8 +8 @@
 use Padre::Wx       ();
 use Padre::Wx::Menu ();
-use Padre::Current qw{_CURRENT};
+use Padre::Current  ('_CURRENT');
 
 our $VERSION = '0.56';
@@ -127 +127 @@
     $self->{run_command}->Enable(1);
     $self->{stop}->Enable(0);
-    $self->{main}->refresh_toolbar(_CURRENT);
     return;
 }
@@ -137 +136 @@
     $self->{run_command}->Enable(0);
     $self->{stop}->Enable(1);
-    $self->{main}->refresh_toolbar(_CURRENT);
     return;
 }

trunk/Padre/lib/Padre/Wx/Menu/View.pm

@@ -51 +51 @@
 
     # Show or hide GUI elements
-    for my $element (@GUI_ELEMENTS) {
+    foreach my $element (@GUI_ELEMENTS) {
 
         next unless defined($element);

trunk/Padre/lib/Padre/Wx/Menubar.pm

@@ -117 +117 @@
     my @items;
 
-    for my $item ( split( /\;/, $config->main_menubar_items ) ) {
+    foreach my $item ( split( /\;/, $config->main_menubar_items ) ) {
         if ( $item eq 'menu._document' ) {
             next unless defined( $main->current );
@@ -145 +145 @@
 
     my $count = -1;
-    for my $item (@items) {
+    foreach my $item (@items) {
         if ( $item =~ /^menu\.(.+)$/ ) {
             my $menu = $1;
@@ -198 +198 @@
                 # is a collision
                 $title =~ s/\&//g;
-                for my $pos ( 0 .. ( length($title) - 1 ) ) {
+                foreach my $pos ( 0 .. ( length($title) - 1 ) ) {
                     my $char = lc( substr( $title, $pos, 1 ) );
 

trunk/Padre/lib/Padre/Wx/Notebook.pm

@@ -72 +72 @@
 }
 
+
+
+
+
 ######################################################################
 # Main Methods
@@ -92 +96 @@
 }
 
+
+
+
+
 ######################################################################
 # Event Handlers
@@ -98 +106 @@
     my $self   = shift;
     my $main   = $self->main;
+    my $lock   = $main->lock('UPDATE', 'refresh', 'refresh_outline');
     my $editor = $self->current->editor;
-    if ($editor) {
+
+    if ( $editor ) {
         my $history = $main->{page_history};
         my $current = Scalar::Util::refaddr($editor);
@@ -108 +118 @@
         # TO DO: Violates encapsulation
         $editor->{Document}->set_indentation_style;
+    }
 
-        # make sure the outline is refreshed for the new doc
-        # TO DO: Violates encapsulation
-        if ( $main->has_outline ) {
-            $main->outline->clear;
-            $main->outline->force_next(1);
-        }
-    }
-    $main->refresh;
     $main->{ide}->plugin_manager->plugin_event('editor_changed');
 }

trunk/Padre/lib/Padre/Wx/Outline.pm

@@ -115 +115 @@
 }
 
+sub refresh {
+    my $self = shift;
+    $self->clear;
+    $self->force_next(1);
+}
+
 sub running {
     !!( $_[0]->{timer} and $_[0]->{timer}->IsRunning );

trunk/Padre/lib/Padre/Wx/Syntax.pm

@@ -302 +302 @@
     my $self = shift;
 
-    for my $i ( 0 .. 2 ) {
+    foreach my $i ( 0 .. 2 ) {
         my $col = $self->GetColumn($i);
         $col->SetText( _get_title($i) );

trunk/Padre/lib/Padre/Wx/ToolBar.pm

@@ -53 +53 @@
     # within config.yml.
 
-    for my $item ( split( /\;/, $config->main_toolbar_items ) ) {
+    foreach my $item ( split( /\;/, $config->main_toolbar_items ) ) {
 
         if ( $item eq '|' ) {
@@ -139 +139 @@
     my $selection = ( defined $text and $text ne '' ) ? 1 : 0;
 
-    for my $item ( keys( %{ $self->{item_list} } ) ) {
+    foreach my $item ( keys( %{ $self->{item_list} } ) ) {
 
         my $action = $self->{item_list}->{$item};

trunk/Padre/script/padre

@@ -131 +131 @@
 
 if ($PRELOAD) {
-
     # Load the entire application into memory immediately
     Padre->import(':everything');
+#   use Aspect;
+#   aspect( 'NYTProf',
+#       call qr/^Padre::/ &
+#       call qr/\b(?:refresh|update)\w*\z/ & !
+#       call qr/^Padre::(?:Locker|Wx::Progress)::/
+#   );
 }
 

trunk/Padre/share/examples/absolute_beginner/05_do_it_again.pl

@@ -72 +72 @@
 # Perl could also be used for cooking:
 
-for my $fruit ( "Orange", "Apple", "Strawberry", "Melon", "Lemon" ) {
+foreach my $fruit ( "Orange", "Apple", "Strawberry", "Melon", "Lemon" ) {
     print "1 $fruit\n";
 }

trunk/Padre/share/examples/absolute_beginner/07_short_salat.pl

@@ -51 +51 @@
     # Sounds like a job for a loop and I'll start with a for try
 
-    for my $argument_number ( 0 .. 2 ) {
+    foreach my $argument_number ( 0 .. 2 ) {
         print $_[$argument_number] . "\n";
     }
@@ -81 +81 @@
     # variables until now, but this can't wait any longer
 
-    for my $argument_number ( 0 .. $number_of_items ) {
+    foreach my $argument_number ( 0 .. $number_of_items ) {
 
         # The number of the first argument is fixed, so there is no need to push it
@@ -105 +105 @@
     my $number_of_items = $_[0];
 
-    for my $argument_number ( 1 .. $number_of_items ) {
+    foreach my $argument_number ( 1 .. $number_of_items ) {
         print "Cut " . $_[$argument_number] . " in stripes\n";
     }
@@ -114 +114 @@
     my $number_of_items = $_[0];
 
-    for my $argument_number ( 1 .. $number_of_items ) {
+    foreach my $argument_number ( 1 .. $number_of_items ) {
         print "Cut " . $_[$argument_number] . " in pieces\n";
     }

trunk/Padre/t/94-padre-file-remote.t

@@ -47 +47 @@
 );
 
-for my $url ( keys(%HTTP_Tests) ) {
+foreach my $url ( keys(%HTTP_Tests) ) {
     $file = Padre::File->new($url);
     ok( defined($file), 'HTTP ' . $url . ': Create Padre::File object' );
@@ -94 +94 @@
 
 # Test some FTP servers
-for my $url (
+foreach my $url (
     'ftp://ftp.ubuntu.com/ubuntu/project/ubuntu-archive-keyring.gpg',
     'ftp://ftp.proftpd.org/README.MIRRORS',                        # Proftpd

trunk/Padre/xt/actions.t

@@ -68 +68 @@
 
 # Run the action checks...
-for my $action (sort(keys(%{$VAR1->{actions}}))) {
+foreach my $action (sort(keys(%{$VAR1->{actions}}))) {
 
  if ($action =~ /^run\./) {

trunk/Padre/xt/mimetype.t

@@ -54 +54 @@
 
 # Some fixed test texts
-for my $text (sort(keys(%test_texts))) {
+foreach my $text (sort(keys(%test_texts))) {
     is(Padre::MimeTypes->guess_mimetype($text,''),$test_texts{$text},$test_texts{$text});
 }
 
 # Some fixed test filenames
-for my $file (sort(keys(%test_files))) {
+foreach my $file (sort(keys(%test_files))) {
     is(Padre::MimeTypes->guess_mimetype('',$file),$test_files{$file},$file);
 }