Changeset 2212

Timestamp:

12/28/08 06:55:52 (3 years ago)

Author:

szabgab

Message:

more beginners related test

Location:

trunk/Padre

Files:

• lib/Padre/Document/Perl/Beginner.pm (modified) (1 diff)
• t/75-perl-beginner.t (modified) (1 diff)
• t/files/beginner/split2.pl (added)

trunk/Padre/lib/Padre/Document/Perl/Beginner.pm

@@ -3 +3 @@
 use strict;
 use warnings;
+
+=head1 NAME
+
+Padre::Document::Perl::Beginner - naive implementation of some beginner specific error checking
+
+=head1 SYNOPSIS
+
+ use Padre::Document::Perl::Beginner;
+ my $b = Padre::Document::Perl::Beginner->new;
+ if (not $b->check($data)) {
+    warn $b->error;
+ }
+
+=head1 DESCRIPTION
+
+This is a naive implementation. It needs to be replaces by one using L<PPI>.
+
+In Perl 5 there are lots of pitfals the unaware, especially
+the beginner can easily fall in.
+This module provides a method called C<check> that can check a perl script 
+(provided as parameter as a single string) and recognize problematic code.
+
+=head1 Examples
+
+ split /,/, @data;
+ 
+Here @data is in scalar context returning the number of elemenets. Spotted in this form:
+
+ split /,/, @ARGV;
+
+
+See L<http://padre.perlide.org/ticket/52> and L<http://www.perlmonks.org/?node_id=728569>
+
+
+=head1 COPYRIGHT
+
+Copyright 2008 Gabor Szabo. L<http://www.szabgab.com/>
+
+=head1 LICENSE
+
+This program is free software; you can redistribute it and/or
+modify it under the same terms as Perl 5 itself.
+
+=head1 WARRANTY
+
+There is no warranty whatsoever.
+
+=head1 CREDITS and THANKS
+
+
+
+=cut
+
 
 sub new {

trunk/Padre/t/75-perl-beginner.t

@@ -17 +17 @@
 BEGIN { $tests += 1; }
 
-SCOPE: {
-    my $data = slurp (File::Spec->catfile('t', 'files', 'beginner', 'split1.pl'));
-    ok(! defined($b->check($data)), 'split1.pl');
-    is($b->error, "The second parameter of split is a string, not an array", "split1.pl error");
-    BEGIN { $tests += 2; }
+my %tests = (
+    'split1.pl' => "The second parameter of split is a string, not an array",
+    'split2.pl' => "The second parameter of split is a string, not an array",
+);
+
+foreach my $file (keys %tests) {
+    my $data = slurp (File::Spec->catfile('t', 'files', 'beginner', $file));
+    ok(! defined($b->check($data)), $file);
+    is($b->error, $tests{$file}, "$file error");
+    BEGIN { $tests += 2 * 2; }
 }