Changeset 2213

Timestamp:

12/28/08 07:12:04 (3 years ago)

Author:

szabgab

Message:

check for use warning without and s

Location:

trunk/Padre

Files:

• lib/Padre/Document/Perl/Beginner.pm (modified) (1 diff)
• t/75-perl-beginner.t (modified) (2 diffs)
• t/files/beginner/warning.pl (added)

trunk/Padre/lib/Padre/Document/Perl/Beginner.pm

@@ -77 +77 @@
         }
     }
+    if ($text =~ /use\s+warning\s*;/) {
+        $self->{error} = "You need to write use warnings (with an s at the end) and not use warning.";
+        return;
+    }
+
     return 1;
 }

trunk/Padre/t/75-perl-beginner.t

@@ -17 +17 @@
 BEGIN { $tests += 1; }
 
-my %tests = (
-    'split1.pl' => "The second parameter of split is a string, not an array",
-    'split2.pl' => "The second parameter of split is a string, not an array",
-);
+my %tests;
+BEGIN {
+    %tests = (
+    'split1.pl'  => "The second parameter of split is a string, not an array",
+    'split2.pl'  => "The second parameter of split is a string, not an array",
+    'warning.pl' => "You need to write use warnings (with an s at the end) and not use warning.",
+    );
+}
 
 foreach my $file (keys %tests) {
@@ -26 +30 @@
     ok(! defined($b->check($data)), $file);
     is($b->error, $tests{$file}, "$file error");
-    BEGIN { $tests += 2 * 2; }
+    BEGIN { $tests += 2 * keys %tests; }
 }