Changeset 2214

Timestamp:

12/28/08 07:53:07 (3 years ago)

Author:

szabgab

Message:

add a pre_process call before execution a script from Padre
that allows the checking of the current file for beginner errors.

Location:

trunk/Padre

Files:

• Changes (modified) (1 diff)
• lib/Padre/Config.pm (modified) (1 diff)
• lib/Padre/Document.pm (modified) (1 diff)
• lib/Padre/Document/Perl.pm (modified) (1 diff)
• lib/Padre/Wx/Dialog/Preferences.pm (modified) (2 diffs)
• lib/Padre/Wx/MainWindow.pm (modified) (1 diff)
• t/02-new.t (modified) (1 diff)

trunk/Padre/Changes

@@ -3 +3 @@
 v0.23 ??????????
 
+    Add naive way to locate some of the annoying errors beginners
+        might make that perl does not catch. (SZABGAB)
     Makefile.PL tricks EU:MM into not loading every single dependency,
         making our dependency-heavy Makefile.PL far saner (ADAMK)

trunk/Padre/lib/Padre/Config.pm

@@ -37 +37 @@
     editor_methods            => 'alphabetical',
     editor_codefolding        => 0,
+    editor_perl5_beginner     => 1,
 
     # Indentation settings

trunk/Padre/lib/Padre/Document.pm

@@ -590 +590 @@
 # abstract method, each subclass should implement it
 sub keywords           { return {} }
-sub get_functions      { return () };
-sub get_function_regex { return '' };
+sub get_functions      { return () }
+sub get_function_regex { return '' }
+sub pre_process        { return 1  }
 
 # should return ($length, @words)

trunk/Padre/lib/Padre/Document/Perl.pm

@@ -129 +129 @@
     chdir $dir;
     return qq{"$perl" "$filename"};
+}
+
+sub pre_process {
+    my ( $self ) = @_;
+    my $config = Padre->ide->config;
+
+print "pre\n";
+use Data::Dumper;
+#print Dumper $config;
+    if ($config->{editor_perl5_beginner}) {
+    print "process\n";
+        require Padre::Document::Perl::Beginner;
+        my $b = Padre::Document::Perl::Beginner->new;
+        if ($b->check( $self->text_get )) {
+            return 1;
+        } else {
+            $self->set_errstr( $b->error );
+            return;
+        }
+    }
+
+    return 1;
 }
 

trunk/Padre/lib/Padre/Wx/Dialog/Preferences.pm

@@ -54 +54 @@
             ['Wx::CheckBox',    'editor_use_wordwrap', '',
                 ($config->{editor_use_wordwrap} ? 1 : 0) ],
+        ],
+        [
+            [ 'Wx::StaticText', undef,              Wx::gettext('Perl beginner mode')],
+            ['Wx::CheckBox',    'editor_perl5_beginner', '',
+                ($config->{editor_perl5_beginner} ? 1 : 0) ],
         ],
         [
@@ -172 +177 @@
     $config->{editor_current_line_background_color} =~ s/#//;
 
-    foreach my $f (qw(editor_use_tabs editor_use_wordwrap editor_auto_indentation_style)) {
+    foreach my $f (qw(editor_use_tabs editor_use_wordwrap editor_auto_indentation_style editor_perl5_beginner)) {
         $config->{$f} = $data->{$f} ? 1 : 0;
     }

trunk/Padre/lib/Padre/Wx/MainWindow.pm

@@ -844 +844 @@
     }
     if ($cmd) {
-        $self->run_command( $cmd );
+        if ($document->pre_process) {
+            $self->run_command( $cmd );
+        } else {
+            $self->error( $document->errstr );
+        }
     }
     return;

trunk/Padre/t/02-new.t

@@ -53 +53 @@
         editor_indentwidth            => 4,
         editor_use_tabs               => 1,
+        editor_perl5_beginner         => 1,
 
         search_terms       => [],