Changeset 2219

Timestamp:

12/28/08 11:36:13 (3 years ago)

Author:

szabgab

Message:

add more test cases to the beginner error catching coe

Location:

trunk/Padre/t

Files:

• 75-perl-beginner.t (modified) (1 diff)
• files/beginner/grep_always_true.pl (added)
• files/beginner/my_argv.pl (added)
• files/beginner/return_stronger_than_or.pl (added)
• files/beginner/substitute_in_map.pl (modified) (1 diff)
• files/beginner/unintented_glob.pl (added)

trunk/Padre/t/75-perl-beginner.t

@@ -28 +28 @@
     'chomp.pl'                     => 'TODO',
     'substitute_in_map.pl'         => 'TODO',
+    'unintented_glob.pl'           => 'TODO',
+    'return_stronger_than_or.pl'   => 'TODO',
+    'grep_always_true.pl'          => 'TODO',
+    'mu_argv.pl'                   => 'TODO',
     );
 }
+
+# probably already in some Perl Critic rules
+# lack of use strict; and lack of use warnings; should be also reported.
+
+# this might be also in some Perl Critic rules 
+#my $filename = 'input.txt';
+#open my $fh, '<', $filename || die $!;
+# problem: precedence of || is higher than that of , so the above code is actually
+# the same as:
+# open my $fh, '<', ($filename || die $!);
+# which will only die if the $filename is false, nothing to do with
+# success of failure of open()
+
+
+# without "use warning" this 'works' noiselessly
+# I am not sure we need to look for such as we should always
+# tell users to 'use warnings'
+#my $x = 23;
+#my $z = 3;
+#if ($x = 7) {
+#   print "xx\n";
+#}
+#
+
 
 foreach my $file (keys %tests) {

trunk/Padre/t/files/beginner/substitute_in_map.pl

@@ -9 +9 @@
 # problem: s/// does not return the substituted string so the above should be written as
 # @data = map { s/./X/; $_ } @data;
+# substitute actually returns the number of substitutions which is of course will alway be 1 
+# unless we use global matching: /g