Changeset 469

Timestamp:

10/26/08 01:46:35 (3 years ago)

Author:

szabgab

Message:

allow the opening of the output window on startup
make sure the empty sqare artifact does not show
up even if the output window is closed on startup

Location:

trunk

Files:

• lib/Padre/Config.pm (modified) (1 diff)
• lib/Padre/Wx/MainWindow.pm (modified) (2 diffs)
• lib/Padre/Wx/Menu.pm (modified) (1 diff)
• lib/Padre/Wx/Output.pm (modified) (1 diff)
• t/02-new.t (modified) (1 diff)

trunk/lib/Padre/Config.pm

@@ -109 +109 @@
     # Look and feel preferences
     $self->{main_statusbar}           ||= 1;
+    $self->{main_output}              ||= 0;
     $self->{editor_tabwidth}          ||= 4;
     $self->{editor_linenumbers}       ||= 0;

trunk/lib/Padre/Wx/MainWindow.pm

@@ -210 +210 @@
         $self,
         -1,
-        sub { $_[0]->on_toggle_status_bar; $_[0]->refresh_all; },
+        sub { 
+            $_[0]->on_toggle_status_bar; 
+            $_[0]->refresh_all;
+
+            my $output = $_[0]->{menu}->{view_output}->IsChecked;
+            # Firs we show the output window and then hide it if necessary
+            # in order to avoide some weird visual artifacts (empty square at
+            # top left part of the whole application)
+            # TODO maybe some users want to make sure the output window is always
+            # off at startup.
+            $_[0]->show_output(1);
+            $_[0]->show_output($output) if not $output;
+            },
     );
     $timer->Start( 500, 1 );
@@ -1113 +1125 @@
 sub show_output {
     my $self = shift;
-    my $on   = @_ ? $_[0] ? 1 : 0 : 1;
+    my $on   = @_ ? $_[0] ? 1 : 0 : $self->{menu}->{view_output}->IsChecked;
+    my $config = Padre->ide->config;
+    $config->{main_output} = $on;
     unless ( $on == $self->{menu}->{view_output}->IsChecked ) {
         $self->{menu}->{view_output}->Check($on);

trunk/lib/Padre/Wx/Menu.pm

@@ -481 +481 @@
         $menu->{view_statusbar}->Check( $config->{main_statusbar} ? 1 : 0 );
     }
+    $menu->{view_output}->Check( $config->{main_output} ? 1 : 0 );
+
     $menu->{view_indentation_guide}->Check( $config->{editor_indentationguides} ? 1 : 0 );
     $menu->{view_show_calltips}->Check( $config->{editor_calltips} ? 1 : 0 );

trunk/lib/Padre/Wx/Output.pm

@@ -25 +25 @@
     );
 
-    # By definition the output window is not shown by default.
-    # Therefore, we should Freeze the widget to stop it attempt to render anything,
-    # which has been a cause of weird visual artifacts in the past.
-    $self->Freeze;
-
     # Do custom startup stuff here
 

trunk/t/02-new.t

@@ -44 +44 @@
         main_startup       => 'new',
         main_statusbar     => 1,
+        main_output        => 0,
         projects           => {},
         run_save           => 'same',