Changeset 5612

Timestamp:

06/26/09 13:16:45 (3 years ago)

Author:

claudio

Message:

Refactor selection buffer to a constant with a comment warning about a reasonable size

File:

• trunk/Padre-Plugin-PerlTidy/lib/Padre/Plugin/PerlTidy.pm (modified) (3 diffs)

trunk/Padre-Plugin-PerlTidy/lib/Padre/Plugin/PerlTidy.pm

@@ -24 +24 @@
 use Padre::Wx      ();
 use Padre::Plugin  ();
-
-our $VERSION = '0.07';
+use constant {  SELECTIONSIZE => 40, }; # this constant is used when storing 
+                    # and restoring the cursor position.
+                    # Keep it small to limit resource use.
+our $VERSION  = '0.07';
 our @ISA     = 'Padre::Plugin';
 
@@ -231 +233 @@
     # parameter: $main, compiled regex
     my ( $main, $regex, $start ) = @_;
-    my $shuffle = 40;
     my $doc     = $main->current->document;
     my $editor  = $doc->editor;
     my $text    = $editor->GetTextRange(
-        ( $start - $shuffle ) > 0 ? $start - $shuffle
+        ( $start - SELECTIONSIZE ) > 0 ? $start - SELECTIONSIZE
         : 0,
-        ( $start + $shuffle < $editor->GetLength() ) ? $start + $shuffle
+        ( $start + SELECTIONSIZE < $editor->GetLength() ) ? $start + SELECTIONSIZE
         : $editor->GetLength()
     );
@@ -260 +261 @@
     my $editor = $doc->editor;
     my $pos    = $editor->GetCurrentPos;
-
-    # A smaller selection to save memory 
-    my $sel_width = 40;    # chars before
     my $start;
 
-    if ( ( $pos - $sel_width ) > 0 ) {
-        $start = $pos - $sel_width;
+    if ( ( $pos - SELECTIONSIZE ) > 0 ) {
+        $start = $pos - SELECTIONSIZE;
     }
     else {