Changeset 5879

Timestamp:

07/06/09 05:19:49 (3 years ago)

Author:

szabgab

Message:

show the number of lines on the GoTo? window #439

Location:

trunk/Padre

Files:

• Changes (modified) (1 diff)
• lib/Padre/Wx/Main.pm (modified) (2 diffs)

trunk/Padre/Changes

@@ -18 +18 @@
     - Add menu option to show selection as hexa or as decimal. (#36) (SZABGAB)
     - Switch to Locale::Msgfmt and generate the .mo files at install time (RSN)
+    - Add number of lines to GoTo line dialog (#439) (SZABGAB)
 
 0.38 2009.06.27

trunk/Padre/lib/Padre/Wx/Main.pm

@@ -2063 +2063 @@
 sub on_goto {
     my $self        = shift;
+    
+    my $editor = $self->current->editor;
+    my $max = $editor->GetLineCount;
     my $line_number = $self->prompt(
-        Wx::gettext("Line number:"),
+        sprintf(Wx::gettext("Line number between (1-%s):"), $max),
         Wx::gettext("Go to line number"),
         "GOTO_LINE_NUMBER"
@@ -2070 +2073 @@
     return if not defined $line_number or $line_number !~ /^\d+$/;
 
-    # TODO: What if it is bigger than buffer?
-    my $page = $self->current->editor;
+    $line_number = $max if $line_number > $max;
     $line_number--;
-    $page->goto_line_centerize($line_number);
+    $editor->goto_line_centerize($line_number);
 
     return;