Changeset 8555

Timestamp:

10/03/09 03:57:22 (2 years ago)

Author:

Sewi

Message:

Fixed most of the test errors

File:

• trunk/Padre/lib/Padre/Document/Perl/Beginner.pm (modified) (4 diffs)

trunk/Padre/lib/Padre/Document/Perl/Beginner.pm

@@ -67 +67 @@
     my $editor   = $document->{editor};
 
-    my $line = $editor->LineFromPosition( length($1) );
+    my $prematch = $1 || '';
+    my $error_start_position = length($prematch);
+
+    my $line = $editor->LineFromPosition( $error_start_position );
     ++$line; # Editor starts counting at 0
 
@@ -78 +81 @@
 sub check {
     my ( $self, $text ) = @_;
-    $self->{error} = undef;
+
+    # TODO: Change this back to undef:
+    $self->{error} = '';
 
 =item *
@@ -210 +215 @@
 
     if ( ( $text =~ /^(.*?)open[\s\t\r\n]*\(?\$?\w+[\s\t\r\n]*(\,.+?)?[\s\t\r\n]*\,[\s\t\r\n]*?([\"\'])(.*?)\|(.*?)\2/ )
-        and ( length($3) > 0 )
-        and ( length($4) > 0 ) )
+        and ( length($4) > 0 )
+        and ( length($5) > 0 ) )
     {
+        print STDERR join(',',map { "[[$_]]"; }($1,$2,$3,$4,$5,$6))."\n";
         $self->_report("Using a | char in open without a | at the beginning or end is usually a typo.");
         return;
@@ -236 +242 @@
 =cut
 
-    if ( $text =~ m{^(.*?)\=\~  [\s\t\r\n]*  \/ \^?  [\+\*\?\{] }xs ) {
+    if ( $text =~ m/^(.*?)\=\~  [\s\t\r\n]*  \/ \^?  [\+\*\?\{] /xs ) {
         $self->_report(
             "A regular expression starting with a quantifier ( + * ? { ) doesn't make sense, you may want to escape it with a \\."