Changeset 9001

Timestamp:

11/01/09 18:40:41 (2 years ago)

Author:

szabgab

Message:

fix #646, Test::NoWarnings? hiding missing prerequisites

Location:

trunk/Padre

Files:

• Changes (modified) (2 diffs)
• Makefile.PL (modified) (2 diffs)

trunk/Padre/Changes

@@ -2 +2 @@
 
 0.49 to be released
-    - Fixed #691: Extect subroutine does not work for a script without
+    - Fixed #691: Extract subroutine does not work for a script without
       subroutines (WAXHEAD)
     - Bugfix: The split-beginner-error check got false positives (SEWI)
@@ -30 +30 @@
       document types (SEWI)
     - Modules/Plugins could now add their panels to the global preferences (SEWI)
+    - Workaround for Test::NoWarnings hiding issue which lead to missing
+      prerequisites or upgrades (#646 SZABGAB)
 
 0.48 2009.10.12

trunk/Padre/Makefile.PL

@@ -9 +9 @@
 use POSIX qw(locale_h);
 
+# workaround for the fact that Module::Install loads the modules
+# into memory and when Test::NoWarnings is loaded it will hide
+# the warnings generated from that point.
+# removed in r2208, added again in
+eval  {
+        require Test::NoWarnings;
+        $SIG{__WARN__} = 'DEFAULT';
+};
+
 BEGIN {
     if ( author_context and not eval("use Locale::Msgfmt 0.14; 1;") ) {
@@ -15 +24 @@
 }
 
+
 # Configure-time dependencies MUST be done first
 configure_requires 'ExtUtils::MakeMaker' => '6.52';
 
+# the above line does not seem to force an upgrade
+# the below code might work but not tested
+#eval "use ExtUtils::MakeMaker ()"; # avoid importing prompt() and other subs
+#if ($@) {
+#   print STDERR "Warning: prerequisite ExtUtils::MakeMaker 6.52 not found.\n";
+#   exit 0;
+#} elsif ($ExtUtils::MakeMaker::VERSION <= 6.52) {
+#   print STDERR "Warning: prerequisite ExtUtils::MakeMaker 6.52 not found. We have $ExtUtils::MakeMaker::VERSION.\n";
+#   exit 0;
+#}