Changeset 9658

Timestamp:

12/13/09 03:01:18 (2 years ago)

Author:

szabgab

Message:

try to make sure there is no infinite loop in the _get process, add logger

File:

• trunk/Debug-Client/lib/Debug/Client.pm (modified) (3 diffs)

trunk/Debug-Client/lib/Debug/Client.pm

@@ -232 +232 @@
 }
 
+# TODO shall we add a timeout and/or a number to count down the number
+# sysread calls that return 0 before deciding it is really done
 sub _get {
     my ($self) = @_;
@@ -237 +239 @@
     #my $remote_host = gethostbyaddr($sock->sockaddr(), AF_INET) || 'remote';
     my $buf = '';
-    $self->{new_sock}->sysread($buf, 1024, length $buf) while $buf !~ /DB<\d+>/;
+    while ($buf !~ /DB<\d+>/) {
+        my $ret = $self->{new_sock}->sysread($buf, 1024, length $buf);
+        if (not defined $ret) {
+            die $!; # TODO better error handling?
+        }
+        logger("---- ret '$ret'\n$buf\n---");
+        if (not $ret) {
+            last;
+        }
+    }
+    logger("_get done");
 
     $self->{buffer} = $buf;
@@ -297 +309 @@
 }
 
+sub logger {
+    print "$_[0]\n" if $ENV{DEBUG_LOGGER};
+}
+
+
 =head1 See Also