Changeset 9765

Timestamp:

12/17/09 23:18:10 (2 years ago)

Author:

azawawi

Message:

Fixed Padre crash when closing a Perl 5 script tab quickly while syntax check is on

File:

• trunk/Padre/lib/Padre/Task/SyntaxChecker.pm (modified) (2 diffs)

trunk/Padre/lib/Padre/Task/SyntaxChecker.pm

@@ -89 +89 @@
     }
     return () if not defined $editor;
+    $editor = Scalar::Util::refaddr( $editor );
     $self->{main_thread_only}->{on_finish} = $on_finish if $on_finish;
     $self->{main_thread_only}->{editor} = $editor;
@@ -127 +128 @@
     my $main     = Padre->ide->wx->main;
     my $syntax   = $main->syntax;
-    my $editor   = $self->{main_thread_only}->{editor};
+
+    my $editor = Padre::Current->editor;
+    my $addr   = delete $self->{main_thread_only}->{editor};
+    if ( not $addr or not $editor or $addr ne Scalar::Util::refaddr($editor) ) {
+        # editor reference is not valid any more
+        return 1;
+    }
 
     # Clear out the existing stuff
     $syntax->clear;
-
-    require Padre::Wx;
 
     # If there are no errors, clear the synax checker pane and return.