Opened 3 years ago

Closed 3 years ago

#1165 closed defect (not relevant)

Preferences - Files and Colors - Description and Content-Type show as ARRAY

Reported by: bvierra Owned by:
Priority: major Milestone:
Component: Preference System Version: trunk
Keywords: Cc:

Description

This is for all File Type's and Highlighter's
See attached screenshot.

Perl 5.10.1
Wx 0.9702
wxWidgets 2.8.11
Wx::Perl::ProcessStream? 0.30
PPI 1.215
Padre Version: 0.85
Revision: r14011 (also replicated on 14018)

Attachments (3)

padre-0.85-preferences-filesandcolors.png (30.7 KB) - added by bvierra 3 years ago.
1165.diff (672 bytes) - added by bvierra 3 years ago.
Propsed patch
1165-2.diff (663 bytes) - added by bvierra 3 years ago.
Patch to fix the not saving issue

Download all attachments as: .zip

Change History (10)

Changed 3 years ago by bvierra

comment:1 Changed 3 years ago by claudio

  • Owner changed from szabgab to claudio
  • Status changed from new to assigned

Changed 3 years ago by bvierra

Propsed patch

comment:2 Changed 3 years ago by claudio

  • Component changed from admin to editor
  • Owner claudio deleted
  • Version changed from 0.85 to trunk

UI in Preferences is fixed (r14019).

However, the settings are not applied. This bug seem to exist in several versions already.

Changed 3 years ago by bvierra

Patch to fix the not saving issue

comment:3 Changed 3 years ago by bvierra

The attached diff (1165-2.diff) fixes the saving issue. Confirmed in 1409

comment:4 Changed 3 years ago by claudio

Thank you, bvierra.

I applied the patch and it's certainly part of the solution. HOWEVER:

  • The new highlighter is only active when reopening the file. In the past, I changed the open file in real time. I guess we need to refresh the editor or something like that.

comment:5 Changed 3 years ago by claudio

Improved logic of update_description and update_highlighters (r14036). The correct lexer is correctly applied and description and mimetype correctly printed.

Issues left:

  1. The field in the statusbar that shows the lexer in use is only updated when changing editor tab. The correct lexer is used, though.
  2. The Preferences Dialig defaults to Perl - Scintilla every time it is reopened (a new object is created). This is clearly unwanted behaviour.

comment:6 Changed 3 years ago by szabgab

  • Component changed from editor to Preference System

comment:7 Changed 3 years ago by adamk

  • Resolution set to not relevant
  • Status changed from assigned to closed

Removed this entire section of preferences, no longer relevant

Note: See TracTickets for help on using tickets.