Opened 3 years ago

Closed 3 years ago

#1260 closed enhancement (not relevant)

fix for :- This violates encapsulation

Reported by: bowtie Owned by: Alias
Priority: minor Milestone:
Component: editor Version: 0.87
Keywords: introspection Cc:

Description

Fix for:

644 # NOTE: This violates encapsulation. The plugin manager should be
645 # manipulated from the outside, it shouldn't introspect it's parent IDE

  • lib/Padre/PluginManager.pm

     
    641641        $config->set( enabled => 0 ); 
    642642    } 
    643643 
    644     # NOTE: This violates encapsulation. The plugin manager should be 
    645     # manipulated from the outside, it shouldn't introspect it's parent IDE 
    646     unless ( $config->enabled or $self->current->ide->{with_plugin}->{$module} ) { 
     644    # Is Plugin enabled -> $tuple[0][2] in config.db 
     645    my @tuple = Padre::DB::Plugin->select('WHERE name = ?',$module); 
     646    unless ($tuple[0][2]) { 
    647647        $plugin->status('disabled'); 
    648648        return; 
    649649    } 

Change History (1)

comment:1 Changed 3 years ago by bowtie

  • Resolution set to not relevant
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.