Ticket #1266 (closed enhancement: fixed)
Padre::Plugin::PerlCritic, fix for missing version
| Reported by: | bowtie | Owned by: | azawawi |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | plugins | Version: | 0.87 |
| Keywords: | missing version | Cc: |
Description
Padre::Plugin::PerlCritic, fix for missing version, so as to be able to run from trunk, also menu mod,
-
lib/Padre/Plugin/PerlCritic.pm
7 7 use warnings; 8 8 use Padre::Wx (); 9 9 use Padre::Plugin (); 10 our $VERSION = 0.12; 10 11 11 12 our @ISA = 'Padre::Plugin'; 12 13 … … 18 19 Wx::gettext('Perl Critic'); 19 20 } 20 21 21 sub menu_plugins _simple{22 sub menu_plugins { 22 23 my $self = shift; 23 return $self->plugin_name => [ 24 Wx::gettext('Perl::Critic Current Document') => sub { 25 $self->critic(@_); 26 } 27 ]; 24 my $main = shift; 25 26 # Create a manual menu item 27 my $item = Wx::MenuItem->new( 28 undef, 29 -1, 30 $self->plugin_name, 31 ); 32 Wx::Event::EVT_MENU( 33 $main, 34 $item, 35 sub { 36 local $@; 37 eval { 38 $self->critic(@_); 39 }; 40 }, 41 ); 42 43 return $item; 28 44 } 29 45 30 46 sub critic {
Attachments
Change History
Changed 22 months ago by bowtie
- Attachment PerlCritic.pm.patch added
Note: See
TracTickets for help on using
tickets.

As per previous conversation
I even ran Perl-Critic against plug-in