Ticket #1357 (closed defect: fixed)

Opened 3 years ago

Last modified 2 years ago

"Debugger" menu is shown for non-Perl files

Reported by: zenogantner Owned by: alias, adamk
Priority: trivial Milestone:
Component: Debugger for Perl 5 Version: 0.91
Keywords: Cc:

Description

r17143

How to reproduce:

  • open a plain text file

Result:

  • the "Debugger" menu is shown

What should happen instead:

  • no "Debugger" menu is shown

Change History

comment:1 Changed 3 years ago by bowtie

Hi zeno, go take a look at

http://svn.perlide.org/padre/trunk/Padre-Plugin-Debug/

and I will try to add your suggestion in to Plugin, before it goes in to trunk later.

ps read POD and manually add patches at present :)

good luck, in advance :)

comment:2 Changed 2 years ago by bowtie

  • Component changed from not classified yet to Debugger for Perl 5

comment:3 Changed 2 years ago by bowtie

  • Priority changed from minor to trivial
  • Component changed from Debugger for Perl 5 to editor

Works correctly for sh files

Yes I agree this happens when you open a New file, which is unsaved,
this is nothing to do with debug

comment:4 Changed 2 years ago by zenogantner

For new files this is okay, but it should not happen for normal text files.

For example, open one of the .po files of Padre. They are normal text files, yet you have the Perl/Debug? menus.

comment:5 Changed 2 years ago by zenogantner

I guess this is the "guilty" line:

	my $perl    = !!(
		   Params::Util::_INSTANCE( $current->document, 'Padre::Document::Perl' )
		or Params::Util::_INSTANCE( $current->project, 'Padre::Project::Perl' )
	);

The .po files are in the Padre project. Still no reason to offer debugging.
Is there a reason why debugging should be activated for all files in a Perl project?
I think no.
But maybe someone had something specific+necessary in mind when adding the or here.

comment:6 Changed 2 years ago by bowtie

  • Owner set to alias, adamk
  • Status changed from new to assigned

As Params::Util is one of Alias modules, passed to adamk

comment:7 Changed 2 years ago by bowtie

  • Component changed from editor to Debugger for Perl 5

comment:8 Changed 2 years ago by bowtie

  • Status changed from assigned to closed
  • Resolution set to fixed

fixed in r17598

Note: See TracTickets for help on using tickets.