Opened 3 years ago

Closed 2 years ago

#1388 closed defect (fixed)

Using breakpoints toolbar item on un-named file causes crash

Reported by: tome Owned by: bowtie
Priority: minor Milestone:
Component: Debugger for Perl 5 Version: 0.95
Keywords: breakpoints Cc:

Description

On the latest svn:

If the breakpoints toolbar item is clicked while a file has not yet been named (new file), it executes the code in Breakpoints.pm 'set_breakpoints_clicked'.

The breakpoints SQL query dies there for me because of a null file name, and the error isn't trapped (in svn), and Padre crashes for me.

My guess would be that it makes sense to prompt the user if they should save the file, but I don't know enough about the code to know if we should also do the same if there are any unsaved changes in the file?

Change History (4)

comment:1 Changed 3 years ago by bowtie

  • Component changed from not classified yet to Debugger for Perl 5
  • Owner set to bowtie
  • Status changed from new to accepted

comment:2 Changed 2 years ago by bowtie

  • Priority changed from major to minor

As the tool-bar icon is just a short cut, to protect Padre, it will now only be active against a saved perl file

thanks tome

see r18081

as for the Debug2 Panels see wiki for update.

ps tome i had forgot to test this case, it just seamed illogical to me

comment:3 Changed 2 years ago by bowtie

opps

Last edited 2 years ago by bowtie (previous) (diff)

comment:4 Changed 2 years ago by bowtie

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.