Opened 3 years ago

Closed 2 years ago

#1393 closed defect (fixed)

test 14_warnings.t fails under cpanm set's $ENV{AUTOMATED_TESTING} true

Reported by: AnotherOneAckap Owned by: adamk, azawawi
Priority: major Milestone:
Component: installation Version: 0.94
Keywords: cpanm testing Cc:

Description

see Changeset 17365.
Padre::Document::Perl::Beginner doesn't like 'Padre/Wx/Scintilla?.pm'
need to add it to %skip_files

Index: 14_warnings.t
===================================================================
--- 14_warnings.t	(revision 18156)
+++ 14_warnings.t	(working copy)
@@ -48,6 +48,7 @@
 	'Padre/Wx/Constant.pm'              => 'Bad substitution',
 	'Padre/Wx/Theme.pm'                 => 'Bad substitution',
 	'Padre/Wx/Dialog/Patch.pm'          => 'equals in an if',
+	'Padre/Wx/Scintilla.pm'             => 'PHP language keywords'
 );
 
 my @files = File::Find::Rule->relative->file->name('*.pm')->in('lib');

Change History (5)

comment:1 Changed 3 years ago by bowtie

  • Keywords cpanm testing added
  • Owner set to adamk, azawawi
  • Status changed from new to assigned
  • Summary changed from test 14_warnings.t fails under cpanm to test 14_warnings.t fails under cpanm set's $ENV{AUTOMATED_TESTING} true

Perl 5.15.7
Padre Updated to revision 18158.

kevin@vinny:~/src/Padre/Padre$ prove -lv t/14_warnings.t

not ok 73 - Check Padre/Wx/Scintilla.pm

#   Failed test 'Check Padre/Wx/Scintilla.pm'
#   at t/14_warnings.t line 68.
#          got: 'Line 201: 'elseif' is wrong syntax, correct if 'elsif'.'
#     expected: ''

test's are confused as this refers to keywords, not perl it's self
php line 201,
vbscript line 321,

Last edited 3 years ago by bowtie (previous) (diff)

comment:2 Changed 3 years ago by azawawi

Is this fixed or not in trunk?

comment:3 Changed 3 years ago by bowtie

using perl 5.15.8
export AUTOMATED_TESTING=1
~/.cpan/build/Padre-0.94-Zcd3Os$ prove -lv t/14_warnings.t

not ok 71 - Check Padre/Wx/Scintilla.pm

#   Failed test 'Check Padre/Wx/Scintilla.pm'
#   at t/14_warnings.t line 68.
#          got: 'Line 201: 'elseif' is wrong syntax, correct if 'elsif'.'
#     expected: ''

As far as I could ascertain, the test is just wrong, as this is not an error as it's php

should we just remove this test?

comment:4 Changed 3 years ago by bowtie

This only happens when AUTOMATED_TESTING=1

sorry, I forgot that.

otherwise it passes, ok

comment:5 Changed 2 years ago by bowtie

  • Resolution set to fixed
  • Status changed from assigned to closed

fixed in r19118

added Padre/Wx/Scintilla?.pm to skip list

Note: See TracTickets for help on using tickets.