Opened 2 years ago

Closed 2 years ago

#1427 closed enhancement (fixed)

Debug::Client 0.20 test failures against win32 or not!

Reported by: bowtie Owned by: bowtie
Priority: minor Milestone:
Component: Debug::Client Version:
Keywords: Cc:

Description

Somebody has been a silly billy!

FAIL Debug-Client-0.20 v5.12.4 Windows (Win32)
http://www.cpantesters.org/cpan/report/13fea170-288c-1018-94c9-b89d05085451

FAIL Debug-Client-0.20 v5.14.2 Windows (Win32)
http://www.cpantesters.org/cpan/report/ae735264-92fd-1018-8c44-1c9b05085451

both fail with

Use of uninitialized value $ret in concatenation (.) or string at C:\CPANTesters\cpan\build\Debug-Client-0.20-jzpnsb\blib\lib/Debug/Client.pm line 497.

_logger("---- ret $ret\n$buffer\n---");

This can only happen if

#######
# Internal Method _logger
#######
sub _logger {
    print "LOG: $_[0]\n" if $ENV{DEBUG_LOGGER};
    return;
}

hence this module is failing due to an env bleed issue.

Not sure weather to change to following or just remove the _logger code compleatly

#######
# Internal Method _logger
#######
sub _logger {
    print "LOG: $_[0]\n" if $self->{debug};
    return;
}

This just reaffirms why I hate win32 as it's put red bits in my nice green world :)
http://matrix.cpantesters.org/?dist=Debug-Client%200.20

Change History (1)

comment:1 Changed 2 years ago by bowtie

  • Resolution set to fixed
  • Status changed from new to closed

fixed in Debug::Client 0.21_02

Note: See TracTickets for help on using tickets.