outline entries can become padded (too high) when typing 'has'

[dod]

Hello

I've often been bothered by the outline panel becoming unusable because space between each entry is too wide.

I've finally found a way to reproduce this behavior:

• mkdir -p lib/Test
• save the attached file in this new directory (as Item.pm)
• open the file with padre
• open the outline window
• go just below the 'our $VERSION' line (i.e. line 31)
• type 'has'

you should see the space between the outline items becoming overblown.

All the best

[dod]

sample test file to reproduce outline issue

[bowtie]

I concur :)

[bowtie]

fixed in r19111

it's a poor hack but works, for now :)

[bowtie]

PPI generates

    PPI::Token::Word    'has'
    PPI::Token::Whitespace      '\n'

but PPIx::EditorTools::OutLine? is expecting some thing like

    PPI::Token::Word    'has'
    PPI::Token::Whitespace      ' '

The above hack fixes Padre double spacing when it gets given \n as an attribute,

[bowtie]

here is another snippet, for fun

use Class::Accessor 'antlers';
has first => ( is => 'rw' );
has ;#comment
has second => ( is => 'ro' );

if the ;#comment is removed, syntax checker dose not give an error

[bowtie]

here is the start of a hack to fix

package PPIx::EditorTools::Outline;

sub _Moo_Attributes {
    my ( $self, $ma_node2, $ma_cur_pkg, $ma_thing ) = @_;

    my $line_num = $ma_thing->location->[0];
    my $attrs    = eval $ma_node2->content;
+   if ( $ma_node2->content =~ /[\n|;]/ ) {
+       return;
+   }
        ...

[bowtie]

also

sub find {
...
            next unless defined $node2;

+           # Tests for has followed by new line
+           try {
+               if ( defined $node2->{content} ) {
+                   if ( $node2->{content} =~ /\n/ ) {
+                       next;
+                   }
+               }
+           };
...

[bowtie]

The above patches added to PPIx-EditorTools? 0.15_03

added to ​https://github.com/kevindawson

see ​http://cpan.metacpan.org/authors/id/B/BO/BOWTIE/PPIx-EditorTools-0.15_03.tar.gz

also se for current status ​https://github.com/szabgab/PPIx-EditorTools/network

critiques welcome,

will level open until PPIx-EditorTools? 0.16 is released

[bowtie]

visual result, working

[bowtie]

PPIx-EditorTools 0.15_04 2012.07.11

• suppress warning Exiting eval via next (BOWTIE)

​http://cpan.metacpan.org/authors/id/B/BO/BOWTIE/PPIx-EditorTools-0.15_04.tar.gz

[dod]

I've installed PPIx-EditorTools?-0.15_04 .

With this version, I no longer have problem with the outline spacing in Padre.

Thanks a bunch for the fix.

[bowtie]

info:

​http://cpan.metacpan.org/authors/id/S/SZ/SZABGAB/PPIx-EditorTools-0.17.tar.gz

has been released, looks good to me

dod can you please confirm, then you or I can close this ticket :)

[dod]

padre works fine with PPIx-EditorTools 0.17: no extra space in the outline when I type in new Moose attributes.

Thanks

[dod]

Fixed in padre's dependency (PPIx-EditorTools 0.17)