Ticket #248 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

timeline-*.pl scripts need no #!/usr/bin/perl

Reported by: dam Owned by:
Priority: trivial Milestone:
Component: downstream Version: 0.27
Keywords: Cc:

Description

Hi,

The scripts in share/timeline/ are executed by ORLite::Migrate using

 IPC::Run3::run3( [ $perl, $patch ], ...

$perl being the found Perl interpreter and $patch being the next script from share/timeline/.

What this tells me is that these scripts are never meant to be run just by name, e.g

$ /path/tp/timeline/migrate-1.pl

Because of that, they aren't installed with execute permissions.

Therefore they don't need to start with #!/usr/bin/perl

Having the shebang fools the Debian package checker, lintian, to wonder if these are to be installed with the executable bit turned on.

Trivial patch removing the shebang lines attached.

-- dam

Attachments

timeline-no-shebang.patch (1.1 KB) - added by dam 5 years ago.
trivial patch

Change History

Changed 5 years ago by dam

trivial patch

comment:1 Changed 5 years ago by dam

  • Status changed from new to closed
  • Resolution set to fixed

fixed in r3090

Note: See TracTickets for help on using tickets.