Opened 5 years ago

Closed 5 years ago

Last modified 3 years ago

#295 closed defect (fixed)

SVN Plugin doesn't check for a defined path

Reported by: waxhead Owned by:
Priority: trivial Milestone:
Component: Integrated Version Control Version: 0.33
Keywords: SVN Plugin Cc:

Description

In the SVN Plugin, the sub svn_commit() doesn't check if path is set, therefore an error is emitted:

Use of uninitialized value $path in concatenation (.) or string at /usr/local/share/perl/5.10.0/Padre/Plugin/SVN.pm line 165.

this is fixed with adding a check right after

my $main = Padre->ide->wx->main;
if( ! defined($path) ) {

# error message because we have no path to file for commit.
$main->message("Not path to file, have you saved this file yet?");
return;

}

Sorry for the lack of a diff file...

Change History (3)

comment:1 Changed 5 years ago by waxhead

Whoops.. note that the error message isn't very good:

Not path to file, should read No path to file... but you get the idea.

comment:2 Changed 5 years ago by garu

  • Resolution set to fixed
  • Status changed from new to closed

Fixed on trunk. Please reopen it if you think there are any related issues left.

Thanks for the bug report!

comment:3 Changed 3 years ago by szabgab

  • Component changed from plugins to Integrated Version Control
Note: See TracTickets for help on using tickets.