Opened 5 years ago

Closed 4 years ago

#331 closed defect (fixed)

* saveall doesn't update tabs (ie asterisk still there until you click tab)

Reported by: jquelin Owned by: waxhead
Priority: major Milestone:
Component: editor Version: trunk
Keywords: Cc:

Description

reported by barbie

Attachments (1)

Main.pm.diff (662 bytes) - added by waxhead 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by waxhead

comment:1 Changed 5 years ago by waxhead

Bugger... lost my comments.

This isn't ideal I expect.

I tried to find where to refresh the tab so that the asterisk would disappear. The best I could come up with is SetFocus?() on each of the tabs as they save, and then returning the Focus to the original Tab.

Has an amuzing effect, and it's a bit slow.

I'm putting this up as a patch rather than committing this so that someone who knows better can make a decision on it's use.

comment:2 Changed 5 years ago by waxhead

This is still a problem in the latest version ( 0.47 ).

I still think this is important to fix as when you save all, there is the lingering doubt when the tabs don't update.

This patch will correct the issue, but as I said, it's an amusing effect watching all your tabs cycle through! :)

comment:3 Changed 5 years ago by waxhead

  • Version changed from 0.35 to 0.47

comment:4 Changed 5 years ago by azawawi

  • Owner set to azawawi
  • Status changed from new to assigned

comment:5 Changed 5 years ago by waxhead

It's in the back of my mind that equivilant editors will actually do this, ie cycle through the tabs saving each one as it goes active, with it returning to the original tab.

It's possible that with the fixes with the speed up work Alias has done this might not be so slow, however it could be forgiven if you see your editor is actually doing something and fixing the GUI elements that imply the file is saved or not.

comment:6 Changed 5 years ago by waxhead

  • Owner changed from azawawi to waxhead
  • Version changed from 0.47 to trunk

I'm taking this back as I'm going to commit this patch to trunk... not ideal just before a release I guess, but once it's done and gets some use we might see some comment on it.

comment:7 Changed 5 years ago by waxhead

Committed revision 10168.

comment:8 Changed 4 years ago by waxhead

  • Resolution set to fixed
  • Status changed from assigned to closed

No issues have been raised with the implementation.

Note: See TracTickets for help on using tickets.