Ticket #436 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Help/Current Document does not reload file

Reported by: szabgab Owned by: waxhead
Priority: major Milestone:
Component: editor Version: 0.38
Keywords: Cc:

Description

I was looking at a .pm file and pressed Help/Current? Document.
it showed the page.
I changed something in the document (replace C<> by L<>) and opened the document browser again.
The page was the same as before (no link) so it
seems Docbrowser does NOT reload the document even if I change and save the file.

Change History

comment:1 Changed 5 years ago by waxhead

  • Owner set to submersible_toaster
  • Status changed from new to assigned

Andrew,

This sort of makes some sense ( not reloading the file when it's changed ) otherwise you have to watch each file that's opened in the docbrowser.

In saying that, should we have a CRTL-R to reload the file maybe?

If so, send it back to me and I'll add it in.

comment:2 Changed 5 years ago by szabgab

oh I did not mean to automatically and always (though that could be a feature too) but what I did
is after pressing Help/Current? Document I closed the docbrowser, changed the document and pressed Help/Current? Document again.

So I'd say

  • if Help/Current? Document always fetch the latest
  • It would be probably good to have a reload option in the docbrowser for people who keep it open
  • if the docbrowser is open and one of the files in the editor is on display in the docbrowser then the editor could notify the docbrowser when the file has changed (though this case has all kinds of tricky edge cases)

My ticket originally was opened for the first issue

comment:3 Changed 5 years ago by waxhead

  • Owner changed from submersible_toaster to waxhead

Given Andrew is busy with the swarm stuff, I'll have a crack at adding in the CRTL-R to reload a file.

comment:4 Changed 5 years ago by therek

Just a note, Ctrl-R is already used for 'Find and Replace' dialog.

comment:5 Changed 5 years ago by szabgab

I think this is fixed by r7244

comment:6 Changed 5 years ago by rhebus

looks fixed to me. Help->Current Document always reloads to the current state in editor (even if there are changes since last save). Ctrl-R from within the help browser doesn't reload, nor does F5 (which web browsers use for refresh), but that's a separate issue to this ticket. Should we close this?

comment:7 Changed 5 years ago by szabgab

  • Status changed from assigned to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.