Ticket #437 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Save As doesn't accept path from dialog

Reported by: waxhead Owned by: waxhead
Priority: minor Milestone:
Component: editor Version: trunk
Keywords: Cc:

Description

I'm logging this bug so it doesn't get forgotten.

Trunk: r5773

When you click Save As, the Name: Text entry allows you to type in a name. When you type in a full path, eg /tmp/newfile.txt Padre saves as the new name, but in the same location that the original file was opened from.

This isn't expected behaviour.

I would expect that a path would allow you to save as to that path.

Checked this in gedit and this is the behaviour.

I haven't found where in Padre this is mananged.

Change History

comment:1 Changed 5 years ago by waxhead

This is a fairly straightforward fix.

Using the ->GetPath? method of the FileDialog?, it returns the full path of the file name that you type in.

comment:2 Changed 5 years ago by waxhead

  • Owner set to waxhead
  • Priority changed from major to minor
  • Status changed from new to assigned

I'm taking this one as I just committed the change, but left all the ugly comments in the code, if this doesn't cause any problems in a few days, I'll clean up the code and close this ticket.

comment:3 Changed 5 years ago by waxhead

OK this works fine on windows too.. Noticed that the save as icon isn't in the toolbar, might have to add it...

I'll clean up the code and add in the icon for the toolbar and close this one off.

comment:4 Changed 5 years ago by waxhead

  • Status changed from assigned to closed
  • Resolution set to fixed

Save As Icon is now in the toolbar.

Note: See TracTickets for help on using tickets.