Opened 8 years ago

Closed 7 years ago

#484 closed enhancement (fixed)

Select a complete block from one brace to another

Reported by: Sewi Owned by:
Priority: major Milestone:
Component: editor Version: trunk
Keywords: Cc:

Description

Ctrl+1 finds matching braces, and Shift+Ctrl+1 should find the matching brace and extend the current selection up to it.

Attachments (1)

brace_match_select.patch​ (1.7 KB) - added by karl.forner 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by karl.forner

comment:1 Changed 7 years ago by karl.forner

  • Resolution set to fixed
  • Status changed from new to closed

Made a quick implementation of the requested feature. I could not bind it to CTRL+SHIFT+1 because on my French keyboard it is the combination I have to type to produce the CTRL+1 shortcut, so I bound it to CTRL+4

N.B
I think the implementation of Padre::Wx::Main::on_brace_matching , Padre::Wx::Editor::highlight_braces and my new feature should be refactored to use common methods.

comment:2 Changed 7 years ago by Sewi

  • Resolution fixed deleted
  • Status changed from closed to reopened

Doesn'tWorkForMe in r11048

Did you already apply that patch?

comment:3 Changed 7 years ago by karl.forner

  • Resolution set to fixed
  • Status changed from reopened to closed

Yes now it is applied.

I refactored the implementation in r11105

Modified goto matching brace (CTRL+1) and select to matching brace in order to:

  • use the defined braces
  • respect the inside/outsideness of starting point, meaning that is the cursor is insid

e the braces; its detination point is also inside

  • the select to matching brace should also now work properly if there is an existing se

lection to the right of a closing brace

Note: See TracTickets for help on using tickets.