Ticket #593 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Padre handles directory seperator different in the recent files dialog

Reported by: getty Owned by: getty
Priority: trivial Milestone:
Component: editor Version: 0.46
Keywords: Cc:

Description

I dont know how exactly i made it possible, but i got a specific files 2 times in the recent files dialog, one time with "/" and one time with "\" directory seperator, under windows. I used the padre windows installer.

Attachments

padre_recent_bug.jpg (9.4 KB) - added by getty 5 years ago.
here you can see both files
padre-patch-win32-recent-files.patch (1.5 KB) - added by getty 5 years ago.
patch for the problem

Change History

Changed 5 years ago by getty

here you can see both files

comment:1 Changed 5 years ago by Sewi

  • Owner set to Sewi
  • Status changed from new to accepted

They are two different filenames (they are not equal) even if windows let them point to the same file.

Probably the same: Open a file once with all lowercase and the second time with some uppercase letters - I guess that you'll also see it twice.

comment:2 Changed 5 years ago by Sewi

The original problem is solved by r8129 & r8130.

It still exists, because win-filenames are case-insensitive but Padre handles them case-sensitive.

comment:3 Changed 5 years ago by getty

  • Owner changed from Sewi to getty
  • Status changed from accepted to assigned

i made a fix for that problem, i will assign a patch next or find someone for the commit bit ;)

comment:4 Changed 5 years ago by getty

  • Status changed from assigned to accepted

Changed 5 years ago by getty

patch for the problem

comment:5 Changed 5 years ago by getty

  • Status changed from accepted to closed
  • Resolution set to fixed

the attached patch fixes the case problem

comment:6 Changed 5 years ago by azawawi

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:7 Changed 5 years ago by azawawi

Thanks for your patch. Getty++

We will use 'Win32::API' instead of 'Win32' to avoid an extra dependency.

comment:8 Changed 5 years ago by azawawi

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed in r8138

Note: See TracTickets for help on using tickets.