Opened 5 years ago

Last modified 3 years ago

#645 new defect

Lexically rename variable changes the screen position dramatically (and shouldn't have to)

Reported by: adamk Owned by:
Priority: minor Milestone:
Component: Refactoring Perl 5 Version: 0.47
Keywords: refactoring Cc:

Description

In the current implementation, the "Lexically Rename Variable" function results in a long wait to parse the document (which is not a big deal) followed by a dramatic snap to a new focus and line (which is really annoying).

The Lexically Rename Variable function inherently should never change the line quantity or the position of any code. As a result, we SHOULD be able to remember and keep the position of the editor at the time of the Lexical Rename Variable menu entry being fired and keep it at the end of the replacement.

Change History (5)

comment:1 Changed 5 years ago by zenogantner

  • Keywords refactoring added

comment:2 Changed 4 years ago by zenogantner

note: The current name of this function in the "Refactoring" menu is "Rename Variable".

comment:3 Changed 4 years ago by zenogantner

Also annoying: After you undo a rename, the focus is at the end of the document.

comment:4 Changed 4 years ago by szabgab

  • Component changed from editor to Refactoring Perl 5

comment:5 Changed 3 years ago by whumann

This seems to be worse in recent versions. IIRC the previous behavior was that the editor view jumped to the variable's first occurence, so in many cases it remained within the current sub. Now it seems to always jump to the top of file.

Note: See TracTickets for help on using tickets.