Opened 5 years ago

Last modified 3 years ago

#646 assigned defect

the prereq Test::NoWarnings hides warnings in Makefile.PL

Reported by: szabgab Owned by: szabgab
Priority: frozen Milestone:
Component: editor Version: 0.47
Keywords: Cc:

Description

Try setting the prereq Text::Diff to 1.35 in Makefile.PL of Padre.
Running perl Makefile.PL does not complain about the prereq being too low. If I comment out the test_requires 'Test::NoWarnings?' part I can see the warnings again.

This bug once was fixed with a workaround in Makefile.PL, then the real issue was addressed somewhere but now it happens again.

This can cause missing prereqs being hidden from CPAN.pm and thus not upgraded before the installation of Padre

Change History (7)

comment:1 Changed 5 years ago by adamk

Could this be because the reporter's EU:MM is too old?

comment:2 Changed 5 years ago by szabgab

Indded I have ExtUtils::MakeMaker? 6.50 but the current code of Makefile.PL of Padre does not upgrade it as - at least on my computer - it does not report about the low version as Test::NoWarnings? hides it...

So maybe we should put back the code that was removed in r2208

eval  {
        require Test::NoWarnings;
        $SIG{__WARN__} = 'DEFAULT';
};

BTW if I put back that code and run perl Makefile.PL (after setting the min requrement of Wx::Perl::ProcessStream? 0.22) then I see the warning about it but I still don't see any warning about ExtUtils::MakeMaker? being only 6.50 while 6.52 is required.

Lastly, I am not sure we should require an upgrade to the toolchain (EUMM) in order to install Padre.

comment:3 Changed 5 years ago by szabgab

In r9001 I added the above workaround but it still does not enforce the upgrade of ExtUtils::MakeMaker? - do we really need such a new version?

comment:4 Changed 5 years ago by szabgab

Adam K commented in e-mail:

Yes, it's because their EU:MM is too old, their CPAN client is
ignoring the configure_requires dependencies.

To deal with this, I probably need to upgrade Module::Install to
forcefully check for configure_requires dependencies.

Adam K

comment:5 Changed 5 years ago by szabgab

  • Priority changed from blocker to critical

comment:6 Changed 4 years ago by szabgab

  • Priority changed from critical to frozen

We have the workaround in place so we can reduce the priority of this issue.

comment:7 Changed 3 years ago by bowtie

  • Owner set to szabgab
  • Status changed from new to assigned
Note: See TracTickets for help on using tickets.