Ticket #740 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Add "Find All" to Padre Search Dialog

Reported by: code4pay Owned by: code4pay
Priority: major Milestone:
Component: editor Version: 0.50
Keywords: Search Find Cc: bramble.andrew@…

Description

Instead of having "Count All" I propose (and have written the code) that we list all the finds in a tab at the bottom and make clicking on the relevant entry take you to that line similar to the Syntax check.

Attachments

findall.dif (3.0 KB) - added by code4pay 4 years ago.
diff of changes to existing files,
FindResult.pm (5.5 KB) - added by code4pay 4 years ago.
Additional Module to Display the Find results in bottom Panel

Change History

comment:1 Changed 4 years ago by code4pay

The Code I add has One Issue. If you perform a search then close the editor you performed the search on and try to click on one of the results it will cause Padre to crash. I tried checking if the editor object is still defined but since I it holds a reference to the editor object it stays defined even when the corresponding editor tab is closed.

comment:2 Changed 4 years ago by submersible_toaster

  • Cc bramble.andrew@… added

Changed 4 years ago by code4pay

diff of changes to existing files,

Changed 4 years ago by code4pay

Additional Module to Display the Find results in bottom Panel

comment:3 Changed 4 years ago by code4pay

Fixed Editor crash when editor no longer open. Fixed issue if bottom aui panel is not open. Added Pod.

comment:4 Changed 4 years ago by submersible_toaster

  • Owner set to submersible_toaster
  • Status changed from new to accepted

comment:5 Changed 4 years ago by submersible_toaster

  • Owner changed from submersible_toaster to code4pay
  • Status changed from accepted to assigned

on trunk @9144 with many thanks to code4pay.

Nice patch. Please mark as fixed.

comment:6 Changed 4 years ago by submersible_toaster

I made one small change to your patch to test defined rather that negate the 'find_id_of_editor' , since the 0 editor is also a valid choice.

comment:7 Changed 4 years ago by Sewi

  • Status changed from assigned to closed
  • Resolution set to fixed

Published in 0.51 release, closing ticket.

Note: See TracTickets for help on using tickets.