Ticket #750 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

tab / ctrl+tab do not work anymore

Reported by: jquelin Owned by: waxhead
Priority: blocker Milestone:
Component: editor Version: 0.50
Keywords: Cc:

Description

tab / ctrl+tab used to change to next/previous file. they don't anymore.

Change History

comment:1 Changed 4 years ago by Sewi

Windows 7: Worksforme
Ubuntu netbook remix: Doesn't work

Which OS are you using?

comment:2 Changed 4 years ago by jquelin

mandriva
padre 0.50
gtk+ 2.18.3

comment:3 Changed 4 years ago by Sewi

Exchanging Ctrl-Tab with Ctrl-K workes on Ubuntu, same for Ctrl-Shift-K.

comment:4 Changed 4 years ago by waxhead

Vista doesn't work for me.

No CRTL-Tab nor can I use CRTL-K.

comment:5 Changed 4 years ago by Sewi

Ctrl-K only works if you change the Padre source:

Padre/Action/Window?.pm line 32 (as of r9228):
Change the Ctrl-Tab to anything you like (and which isn't used otherwise), start a new Padre and try your new shortcut.

I didn't commit Ctrl-K as Ctrl-Tab is the expected shortcut and shouldn't be changed.

comment:6 Changed 4 years ago by Sewi

New expected behavior:

  • Alt-Left/Alt?-Right go to the panel left/right from the current.
  • Ctrl-Tab goes to the last visited (multiple times = 2nd last, 3rd last, etc.)
  • Ctrl-Shift-Tab goes to the oldest visited tab (multiple times work here, too)

But Ctrl-Tab & Ctrl-Shift-Tab are still out of order. :-(

comment:7 Changed 4 years ago by Sewi

  • Priority changed from major to blocker

comment:8 Changed 4 years ago by Sewi

  • Status changed from new to closed
  • Resolution set to fixed

Fixed in r 9624

waxhead++ for doing the other half of the fix

comment:9 Changed 4 years ago by waxhead

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:10 Changed 4 years ago by waxhead

  • Owner set to waxhead
  • Status changed from reopened to assigned

The crtl tabbing wasn't quite working correctly. The effect of the change would see Padre::Main::key_up called twice.

comment:11 Changed 4 years ago by waxhead

commited fix as r9630.

comment:12 Changed 4 years ago by waxhead

  • Status changed from assigned to closed
  • Resolution set to fixed

Crtl-Tab is working again, judicious use of ->Skip(1) and (0) does the job.

comment:13 Changed 4 years ago by patspam

  • Status changed from closed to reopened
  • Resolution fixed deleted

Ctrl-Tab is using tab display order rather than last-used order (Ubuntu 9.10, Padre 0.52).

comment:14 Changed 4 years ago by Sewi

  • Status changed from reopened to closed
  • Resolution set to fixed

Error has nothing to do with original ticket, moved to new ticket.

comment:15 Changed 4 years ago by waxhead

yeah, it's not ever used last used order. It's in the code TODO.

Note: See TracTickets for help on using tickets.