Preferences dialog should NOT explicit'ify defaults
|Reported by:||adamk||Owned by:|
Starting from a fresh configuration, changing a single setting in the preferences dialog results in dozens of settings being saved into the config files.
This should not happen.
The only values that should be saved into the configuration are those where the user has provided some action to NOT accept the default value.
When preference data is read out and applied to the config, it should only be done for values which differ from the default.
This should be done at the dialog level, as calling $config->set( name => $value ) might be done legitimately, if it comes from a user action.
But the 50 values in the preference dialog do NOT come from explicit actions, and so should only be applied to the underlying configuration if they differ from the current value.
This flaw basically breaks the entire defaulting mechanism in the config layer as we can't change any defaults in future and expect them to be picked up. Users will be stuck with the old "default".
Change History (3)
comment:1 Changed 6 years ago by adamk
- Summary changed from Preferences dialog should explicit'ify defaults to Preferences dialog should NOT explicit'ify defaults