Ticket #838 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Author tests should all check RELEASE_TESTING and/or AUTOMATED_TESTING

Reported by: rhebus Owned by: rhebus
Priority: minor Milestone:
Component: editor Version: 0.55
Keywords: Cc:

Description

Some of the xt/* tests check RELEASE_TESTING and/or AUTOMATED_TESTING but most do not. They should all make this check.

Mostly this can be implemented by copying Adam's template from http://cpansearch.perl.org/src/ADAMK/Algorithm-Dependency-1.110/t/98_pod.t (see also http://use.perl.org/~Alias/journal/38822 )

Note also the critic tests should probably only run under RELEASE_TESTING; we shouldn't be bothering CPAN testers with Perl::Critic failures.

Attachments

xt-with-release-checks.diff (4.7 KB) - added by rhebus 4 years ago.
Patch adding checks to xt/*

Change History

comment:1 Changed 4 years ago by rhebus

  • Owner set to rhebus
  • Status changed from new to assigned

comment:2 Changed 4 years ago by azawawi

  • Owner changed from rhebus to azawawi

comment:3 Changed 4 years ago by azawawi

  • Owner changed from azawawi to rhebus

Changed 4 years ago by rhebus

Patch adding checks to xt/*

comment:4 Changed 4 years ago by rhebus

The patch adds checks for RELEASE_TESTING and AUTOMATED_TESTING to all xt/* apart from Perl::Critic tests.
Perl::Critic tests only check for RELEASE_TESTING.

comment:5 Changed 4 years ago by azawawi

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in r10378

I only did whitespace changes to it (spaces->tab). Thanks :)

Note: See TracTickets for help on using tickets.