Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#87 closed enhancement (fixed)

Small patch for enhancing the tabs

Reported by: hjansen Owned by:
Priority: major Milestone:
Component: editor Version: 0.15
Keywords: tabs enhancement patch new file Cc:

Description

Using Wx::AUI one can get enhanced tab functionality for (almost) free.
Also the "New File" button in the toolbar did not work for me (at least not after modifying Padre), so I added an event handler in the same way the Menu setup does it. This modification is also included in the patch.

Attachments (1)

padre.patch (2.3 KB) - added by hjansen 6 years ago.
Patch file

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by hjansen

Patch file

comment:1 follow-up: Changed 6 years ago by szabgab

Thanks for the patch.
I am trying to apply it but there still is an issue:

Now if the file has changed and I click on the [x] on the tab, it will close it without asking.
Also when I click on the close of the window instead of closing the application it just closes the
last tab.
I am trying to fix these now but if you know how to do them, please send a new patch.

Besides, the new toolbar button was already fixed in SVN, so next time, please send patch against the SVN version.

comment:2 in reply to: ↑ 1 Changed 6 years ago by hjansen

Replying to szabgab:

Now if the file has changed and I click on the [x] on the tab, it will close it
without asking.
Also when I click on the close of the window instead of closing the application
it just closes the last tab.

Yes, "close window" will close the application only after the last tab has been closed.
Probably a dialog box ("Close tab or close whole app?") would be appropriate here as long as there is at least one open tab?

I am trying to fix these now but if you know how to do them, please send a
new patch.

Given the fact that I hadn't seen any wxWidgets / wxperl code before yesterday I don't know it off-hand. But I'll try to have a look at it as soon as possible.

Besides, the new toolbar button was already fixed in SVN, so next time,
please send patch against the SVN version.

Yeah, will do - I also noticed that this Ctrl--(_In_creasing)/Ctrl-+(_De_creasing) issue that I stumbled upon and thought of patching is already fixed ;-)

comment:3 Changed 6 years ago by szabgab

After long hours of fight I have managed to implement most of this I think.
It is still in a branch as I need to test it a bit more before I merge it back to trunk.

comment:4 Changed 6 years ago by szabgab

  • Resolution set to fixed
  • Status changed from new to closed

merged to trunk, please try it.

comment:5 Changed 6 years ago by hjansen

Tested, works.

Note: See TracTickets for help on using tickets.